Skip to content

CMake: fix absolute include install dir #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nim65s wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CMake: fix absolute include install dir #702

nim65s wants to merge 1 commit into from

Conversation

@nim65s
Copy link

@nim65s nim65s commented Dec 22, 2025 •
edited
Loading

Hi,

Users may want to provide absolute paths in CMAKE_INSTALL_INCLUDEDIR. When this is the case, we should not prefix it in any way.

Without this, building https://github.com/gazebosim/gz-transport v15 on nixos currently fail with:

CMake Error in test/integration/CMakeLists.txt:
  Imported target "zenohcxx_zenohc" includes non-existent path

    "/nix/store/8vadygf30zr2qlk8cqnnsdjc2h8a72cm-zenoh-cpp-1.4.0//nix/store/8vadygf30zr2qlk8cqnnsdjc2h8a72cm-zenoh-cpp-1.4.0/include"

edit: fix relocatable setup

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

PR missing one of the required labels: {'api-sync', 'new feature', 'breaking-change', 'dependencies', 'enhancement', 'ci', 'documentation', 'internal', 'bug'}

@nim65s
CMake: fix absolute include install dir
7b7f453 
Users may want to provide absolute paths in `CMAKE_INSTALL_INCLUDEDIR`.
When this is the case, we should not prefix it in any way.
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

PR missing one of the required labels: {'new feature', 'bug', 'internal', 'enhancement', 'dependencies', 'documentation', 'breaking-change', 'ci', 'api-sync'}

@nim65s nim65s changed the title CMake: use CMAKE_INSTALL_FULL_INCLUDEDIR CMake: fix absolute include install dir Dec 23, 2025
@DenisBiryukov91 DenisBiryukov91 added the bug Something isn't working label Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nim65s @DenisBiryukov91